Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/postgresql] namespace template helpers with chart name#1777

Merged
dhilipkumars merged 1 commit intohelm:masterfrom
kevinschumacher:namespace-helpers-postgresql
Aug 20, 2017
Merged

[stable/postgresql] namespace template helpers with chart name#1777
dhilipkumars merged 1 commit intohelm:masterfrom
kevinschumacher:namespace-helpers-postgresql

Conversation

@kevinschumacher
Copy link
Contributor

@kevinschumacher kevinschumacher commented Aug 18, 2017

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 18, 2017

Hi @kevinschumacher. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2017
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Aug 20, 2017

@kevinschumacher Could you create an umbrella issue for this activity so that we can understand how many need to be fixed and track it easily, please?

Example issue #1734

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 20, 2017
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Aug 20, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2017
@dhilipkumars dhilipkumars merged commit 1cd194b into helm:master Aug 20, 2017
@kevinschumacher kevinschumacher mentioned this pull request Aug 20, 2017
Closed
@kevinschumacher kevinschumacher deleted the namespace-helpers-postgresql branch August 20, 2017 18:17
@mgoodness mgoodness mentioned this pull request Sep 10, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinschumacher @k8s-ci-robot @dhilipkumars